CakePHP ACL和Auth不起作用(CakePHP ACL and Auth not working)

 你的直觉很好 - 你不想重复自己 ，并且有更好的方法来构造这段代码。 但是，不应该共享变量 ，而应该考虑松散连接的小块 。 编写能很好地完成一件事的方法，并将它们组合在一起。 例如，我们可以编写一个get_client方法，该方法只返回client以供其他方法使用： 
 
protected
def get_client
  client  = Google::APIClient.new(
    application_name: "Example Application",
    application_version: "1.0")

  client.authorization = Signet::OAuth2::Client.new(
    :token_credential_uri => 'https://accounts.google.com/o/oauth2/token',
    :audience             => 'https://accounts.google.com/o/oauth2/token',
    :scope                => 'https://www.googleapis.com/auth/analytics.readonly',
    :issuer               => SERVICE_ACCOUNT_EMAIL_ADDRESS,
    :signing_key          => Google::APIClient::KeyUtils.load_from_pkcs12(PATH_TO_KEY_FILE, 'notasecret')).tap { |auth| auth.fetch_access_token! }
  client
end
 
 它protected因为外部代码 - Analytic类之外的东西 - 不应该直接使用它。 他们应该使用我们为他们提供的方法。 
 
 
 您还可以提供一个帮助方法来从API获取结果。 我不熟悉查询API，但看起来它是您的metrics值发生变化。 也许是这样的： 
 
protected
def get_result(metrics)
  client = self.get_client
  api_method = client.discovered_api('analytics','v3').data.ga.get

  result = client.execute(:api_method => api_method, :parameters => {
    'ids'        => PROFILE,
    'start-date' => Date.new(2014,1,1).to_s,
    'end-date'   => Date.today.to_s,
    'dimensions' => 'ga:pagePath',
    'metrics'    => metrics,
    'filters'    => 'ga:pagePath==/'
   })
  result
end
 
 
 现在您可以编写外部类可以使用的简单方法： 
 
def new_users
  get_result('ga:newUsers')
end

def total_visits
  get_result('ga:pageViews')
end
 
 如果可以，尝试从这些方法返回简单数据。 也许total_visits会返回get_result('ga:pageViews')['totalsForAllResults']['ga:pageviews'] 。 您班外的代码不应该知道使用它的GA数据格式。 这称为封装 。 

Your instincts are good - you don't want to repeat yourself, and there are better ways of structuring this code. But rather than sharing variables, you should think about small pieces, loosely joined. Write methods that do one thing well, and combine them together. For instance, we could write a get_client method that just returns a client for other methods to use:
 
protected
def get_client
  client  = Google::APIClient.new(
    application_name: "Example Application",
    application_version: "1.0")

  client.authorization = Signet::OAuth2::Client.new(
    :token_credential_uri => 'https://accounts.google.com/o/oauth2/token',
    :audience             => 'https://accounts.google.com/o/oauth2/token',
    :scope                => 'https://www.googleapis.com/auth/analytics.readonly',
    :issuer               => SERVICE_ACCOUNT_EMAIL_ADDRESS,
    :signing_key          => Google::APIClient::KeyUtils.load_from_pkcs12(PATH_TO_KEY_FILE, 'notasecret')).tap { |auth| auth.fetch_access_token! }
  client
end
 
It's protected because external code - stuff outside your Analytic class - shouldn't work with it directly. They should use the methods we provide for them. 
 
 
You could also provide a helper method for getting results from the API. I'm not familiar with the query API, but it looks like it's your metrics value that changes. So maybe something like this: 
 
protected
def get_result(metrics)
  client = self.get_client
  api_method = client.discovered_api('analytics','v3').data.ga.get

  result = client.execute(:api_method => api_method, :parameters => {
    'ids'        => PROFILE,
    'start-date' => Date.new(2014,1,1).to_s,
    'end-date'   => Date.today.to_s,
    'dimensions' => 'ga:pagePath',
    'metrics'    => metrics,
    'filters'    => 'ga:pagePath==/'
   })
  result
end
 
 
Now you can write simple methods that your external classes can use: 
 
def new_users
  get_result('ga:newUsers')
end

def total_visits
  get_result('ga:pageViews')
end
 
If you can, try to return simple data from these methods. Maybe total_visits is going to return get_result('ga:pageViews')['totalsForAllResults']['ga:pageviews'] instead. Code outside your class shouldn't have to know about the GA data format to work with it. This is called encapsulation.