我应该在Actions中创建Swing组件吗？(Should I create Swing components within Actions?)

 我正在为我的Swing组件创建Actions，但是，他们经常需要生成一个确认JDialog。 我应该在Action本身内创建这个JDialog，我应该将它传递给Action，还是有替代方法？ 
 
 例 
 
public static class Create extends AbstractAction {
    @Override
    public void actionPerformed(ActionEvent event) {
        int selection = JOptionPane.showConfirmDialog(...);
        // ... processing
    }        
}
 
 这个例子很难进行单元测试，因为它涉及自动选择JDialog（感觉就像代码味）。 
 
 解？ 
 
public static class Create extends AbstractAction {

    private JDialog dialog = null;

    public Create(JDialog dialog) {
        this.dialog = dialog;
    }

    @Override
    public void actionPerformed(ActionEvent event) {
        dialog.display();
        // ... processing
    }        
}

I am creating Actions for my Swing components, however, they often need to generate a confirmation JDialog. Should I be creating this JDialog within the Action itself, should I pass it in to the Action, or is there an alternative method?
 
Example
 
public static class Create extends AbstractAction {
    @Override
    public void actionPerformed(ActionEvent event) {
        int selection = JOptionPane.showConfirmDialog(...);
        // ... processing
    }        
}
 
This example is quite hard to unit test since it involves automating the selection of the JDialog (which feels like a code smell).
 
Solution?
 
public static class Create extends AbstractAction {

    private JDialog dialog = null;

    public Create(JDialog dialog) {
        this.dialog = dialog;
    }

    @Override
    public void actionPerformed(ActionEvent event) {
        dialog.display();
        // ... processing
    }        
}

原文：https://stackoverflow.com/questions/14760130